Add the make_monitor_label method #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2024
leolost2605
force-pushed
the
leolost/monitor-label
branch
2 times, most recently
from
98b1749 to
c85bf6e
Compare
ryonakano
reviewed
Nov 8, 2025
ryonakano
reviewed
Nov 8, 2025
leolost2605
force-pushed
the
leolost/monitor-label
branch
from
c85bf6e to
a00135a
Compare
ryonakano
reviewed
Nov 11, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Confirmed the points I mentioned is fixed, thank you. Unfortunately however, I'm not familiar with the code here so maybe other developers should also take a look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with elementary/gala#2084